fix: component b64 sigs and info #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-stewart
force-pushed
the
jon-stewart/GROW-2781/component-b64-sigs
branch
from
d31335b
to
2a2338c
Compare
dmurray-lacework
approved these changes
Feb 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The CDK prototype code expects a base64 encoded
.signaturefile. The CDK V1 code expects a NON b64 encoded.signaturefile. The fix for this is to treat b64 decoding as optional - if it fails try the signature anyway.It wasn't possible to execute CDK v1 components - the
componentTypewasn't stored. This issue must have been introduced at some stage during development, possibly when tightening up the v1 component exec code path. The fix for this is to store component information in a.infofile.How did you test this change?
Issue
https://lacework.atlassian.net/browse/GROW-2781