Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GROW-2766): add cdk component client #1538

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

ipcrm
Copy link
Contributor

@ipcrm ipcrm commented Feb 14, 2024

Summary

Make it easier to consume the CDK gRPC service from within a go component.

How did you test this change?

Integration tests

Issue

https://lacework.atlassian.net/browse/GROW-2766

@ipcrm ipcrm requested a review from a team as a code owner February 14, 2024 15:07
@ipcrm ipcrm marked this pull request as draft February 14, 2024 15:08
@ipcrm ipcrm force-pushed the ipcrm/GROW-2766/cdk-component-client branch 2 times, most recently from 1823bb2 to 73b018e Compare February 14, 2024 15:53
@ipcrm ipcrm marked this pull request as ready for review February 14, 2024 20:05
@ipcrm ipcrm changed the title feat: add cdk component client feat(GROW-2766): add cdk component client Feb 14, 2024
cli/cdk/client/go/client.go Outdated Show resolved Hide resolved
cli/cdk/client/go/client.go Show resolved Hide resolved
Copy link
Contributor

@PengyuanZhao PengyuanZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ipcrm ipcrm force-pushed the ipcrm/GROW-2766/cdk-component-client branch from d41afb2 to b64b593 Compare February 20, 2024 13:59
@ipcrm ipcrm merged commit 4fca224 into main Feb 20, 2024
7 checks passed
@ipcrm ipcrm deleted the ipcrm/GROW-2766/cdk-component-client branch February 20, 2024 14:30
@lacework-releng lacework-releng mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants