Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Create workflow nightly-build.yml #1535

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

PengyuanZhao
Copy link
Contributor

@PengyuanZhao PengyuanZhao commented Feb 13, 2024

@PengyuanZhao PengyuanZhao changed the title ci: Create nightly-build.yml ci: Create workflow nightly-build.yml Feb 13, 2024
@PengyuanZhao PengyuanZhao marked this pull request as ready for review February 13, 2024 22:41
@PengyuanZhao PengyuanZhao requested a review from a team as a code owner February 13, 2024 22:41
LW_INT_TEST_AWS_ACC: ${{ secrets.LW_INT_TEST_AWS_ACC }}
run: |
sudo apt-get update
sudo apt-get install -y vim
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we install vim?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vim is needed for integrations test of inline editing LQL queries. There is a ticket for having a docker image for this: https://lacework.atlassian.net/browse/GROW-924

@PengyuanZhao PengyuanZhao merged commit 6fa444b into main Feb 15, 2024
5 checks passed
@PengyuanZhao PengyuanZhao deleted the pengyuan/GROW-2758/nightly-build branch February 15, 2024 20:38
@lacework-releng lacework-releng mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants