chore(cli): print new component version available message #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
suggested changes
Feb 12, 2024
There was a problem hiding this comment.
Are we going to print this message on EVERY execution? If so, this is a no-no, it will be too invasive for the customer.
We need to do this message only once a day. Just like our daily version check. And if it is possible, I would recommend printing this message at the end of the command execution, not at the beginning, otherwise it gets lost.
PengyuanZhao
force-pushed
the
pengyuan/GROW-2589
branch
from
89a94a8
to
5aa9049
Compare
|
Updated to only print at the end, once a day, leveraging the existing function. |
afiune
approved these changes
Feb 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dailyComponentUpdateAvailableto check if the component version was checked 1 day ago.How did you test this change?
Issue