Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to choose alignment channel by name #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acorbat
Copy link

@acorbat acorbat commented Jul 23, 2024

While using fileseries I encountered two problems while working with raw files from MACSims:

  1. Not all cycles have the same number of channels
  2. Order of channels was sorted while building the metadata

This made it impossible for me to select a channel for reference just by stating the number. For the first cycle it was the first channel, but for the other cycles it was the last one.

My workaround was to allow passing a string with the channel name. Metadata will then check if align channel is a string, and then check if it's inside channel_map values or not (raise Exception). If it's an int, it will use it as key of the dictionary. If it's not, then it will raise Exception.

I took the liberty of adding this to FilePatternMetadata as well.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant