Add the option to choose alignment channel by name #222
+19
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using fileseries I encountered two problems while working with raw files from MACSims:
This made it impossible for me to select a channel for reference just by stating the number. For the first cycle it was the first channel, but for the other cycles it was the last one.
My workaround was to allow passing a string with the channel name. Metadata will then check if align channel is a string, and then check if it's inside channel_map values or not (raise Exception). If it's an int, it will use it as key of the dictionary. If it's not, then it will raise Exception.
I took the liberty of adding this to FilePatternMetadata as well.
What do you think?