middleware: basic auth middleware can extract and check multiple auth… #2539
+168
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2539 +/- ##
==========================================
+ Coverage 92.89% 93.08% +0.19%
==========================================
Files 39 39
Lines 4658 4659 +1
==========================================
+ Hits 4327 4337 +10
+ Misses 240 235 -5
+ Partials 91 87 -4
☔ View full report in Codecov by Sentry. |
aldas
force-pushed
the
basic_auht_multiple_headers
branch
from
5f9f144
to
6269cab
Compare
laychopy
reviewed
Dec 27, 2023
laychopy
reviewed
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic auth middleware can extract and check multiple auth headers.
This is taken from
v5. Because of #2461 to get better tests inv4for that middleware. Multiple auth headers is rare case. You probably can see this in test environments where application uses JWT token (which is also auth header) but for TEST env Nginx/Apache2 etc is configured to have basic auth for all requests. In that case your web-browser actually will send 2 auth header and it is 50/50 change that your request will pass as when previous version gets the header from Headers map you have 50/50 chance not to get JWT header.