-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(secure): support Content-Security-Policy-Report-Only header #1287
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1287 +/- ##
==========================================
+ Coverage 84.18% 84.21% +0.02%
==========================================
Files 26 26
Lines 1948 1951 +3
==========================================
+ Hits 1640 1643 +3
Misses 202 202
Partials 106 106
Continue to review full report at Codecov.
|
cffb271
to
d1d15da
Compare
d1d15da
to
1881ca4
Compare
@vishr is it possible to include this patch in the next v3 release (whenever that happens). I'm using glide for dependency management and using latest version in v3, and I'm not sure how much work would be involved in moving to v4. |
I think that forking and maintaining both the v4 and v3 would be too much work, but it's really up to @vishr You could consider migrating to Go modules or making your voice heard here: Masterminds/glide#1017 But even so, the project itself is recommending its users to migrate away and that recommendation is like ~1 year old by now:
As Go now has an official dependency management solution, it's probably going to be embraced by the community: it's only a few months old, and there are 1800+ repos using it already. Dep itself was "an experiment" as it clearly states itself, so the long term solution is only one. The sooner you embrace it, the happier you'll be :) |
Yeah, glide is in maintenance mode, so I don't expect changes to come there. It's fine, not a big problem. |
Closes #1283