Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secure): support Content-Security-Policy-Report-Only header #1287

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

kumarharsh
Copy link
Contributor

Closes #1283

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #1287 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
+ Coverage   84.18%   84.21%   +0.02%     
==========================================
  Files          26       26              
  Lines        1948     1951       +3     
==========================================
+ Hits         1640     1643       +3     
  Misses        202      202              
  Partials      106      106
Impacted Files Coverage Δ
echo.go 88.15% <ø> (ø) ⬆️
middleware/secure.go 92.85% <100%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b5044...1881ca4. Read the comment docs.

middleware/secure.go Outdated Show resolved Hide resolved
middleware/secure.go Outdated Show resolved Hide resolved
middleware/secure.go Outdated Show resolved Hide resolved
@vishr vishr merged commit 802fb5b into labstack:master Feb 27, 2019
@kumarharsh kumarharsh deleted the feat/csp-report-only branch February 27, 2019 08:14
@kumarharsh
Copy link
Contributor Author

@vishr is it possible to include this patch in the next v3 release (whenever that happens). I'm using glide for dependency management and using latest version in v3, and I'm not sure how much work would be involved in moving to v4.

@alexaandru
Copy link
Contributor

alexaandru commented Feb 27, 2019

I think that forking and maintaining both the v4 and v3 would be too much work, but it's really up to @vishr

You could consider migrating to Go modules or making your voice heard here: Masterminds/glide#1017

But even so, the project itself is recommending its users to migrate away and that recommendation is like ~1 year old by now:

"The Go community now has the dep project to manage dependencies. Please consider trying to migrate from Glide to dep. ..."

As Go now has an official dependency management solution, it's probably going to be embraced by the community: it's only a few months old, and there are 1800+ repos using it already. Dep itself was "an experiment" as it clearly states itself, so the long term solution is only one. The sooner you embrace it, the happier you'll be :)

@kumarharsh
Copy link
Contributor Author

kumarharsh commented Feb 27, 2019

Yeah, glide is in maintenance mode, so I don't expect changes to come there. It's fine, not a big problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants