Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect behaviour of default output directory on first run #71

Closed
chrisjbillington opened this issue May 1, 2020 · 1 comment · Fixed by #91
Closed

Incorrect behaviour of default output directory on first run #71

chrisjbillington opened this issue May 1, 2020 · 1 comment · Fixed by #91
Assignees
@philipstarkey

Comments

@chrisjbillington
Copy link
Member

Upon first running runmanager after install, when there is no labscript file loaded from a saved config file, it incorrectly has the warning about a non-default output directory displayed:

image

Upon subsequently choosing a labscript file, it doesn't set the output directory correctly:

image

The "set default output directory" button is even greyed out. To workaround, one must choose an output directory manually, then the "set default output directory" button is enabled and can be used to restore things to sanity.
@philipstarkey
Copy link
Member

So this is due to the fix for #69. I think possibly that fix went about it in the wrong way. I think #69 only happened when the labscript file was set when loading in a config (either at startup or manually) because selecting a new labscript file via the GUI called check_output_folder_update() which should always have updated self.previous_default_output_folder so the explicit addition of updating that variable in on_labscript_file_text_changed() is unnecessary.

Possibly the fix should be to remove check_output_folder_update() from on_select_labscript_file_clicked() and modify on_labscript_file_text_changed() to call check_output_folder_update().

@philipstarkey philipstarkey self-assigned this Jun 23, 2020
philipstarkey added a commit to philipstarkey/runmanager that referenced this issue Jun 23, 2020
@philipstarkey
Incorrect behaviour of default output directory on first run
79a2c88 
Fixes labscript-suite#71
@philipstarkey philipstarkey mentioned this issue Jun 23, 2020
Merged
rpanderson pushed a commit to philipstarkey/runmanager that referenced this issue Jun 23, 2020
@philipstarkey @rpanderson
Incorrect behaviour of default output directory on first run
c7f1d7f 
Fixes labscript-suite#71
rpanderson pushed a commit to philipstarkey/runmanager that referenced this issue Jun 23, 2020
@philipstarkey @rpanderson
Incorrect behaviour of default output directory on first run
df99aee 
Fixes labscript-suite#71
philipstarkey added a commit that referenced this issue Jun 25, 2020
@philipstarkey @chrisjbillington @rpanderson
Squashed commit of the following:
61be21f 
commit 6868c8e
Author: Phil Starkey <[email protected]>
Date:   Thu Jun 25 18:43:47 2020 +1000

    Update dependencies in setup.cfg

    Bumped labscript and labscript_utils versions to `>=3.0.0`

commit be2dc40
Merge: 6a7d105 80f272e
Author: Phil Starkey <[email protected]>
Date:   Thu Jun 25 12:17:20 2020 +1000

    Merge pull request #95 from chrisjbillington:use-runviewer-launcher

    Fix issue #92

commit 80f272e
Author: chrisjbillington <[email protected]>
Date:   Wed Jun 24 20:45:17 2020 -0400

    Fix issue #92

    Launch runviewer using the runviewer-gui launcher, for consistency with
    how it would be launched by a human, and to ensure it has a hidden
    console window of its own instead of no console window (the cause of
    issue #92).

commit 6a7d105
Merge: b007f3e df99aee
Author: Russell Anderson <[email protected]>
Date:   Wed Jun 24 08:18:13 2020 +1000

    Merge pull request #91 from philipstarkey/philipstarkey/issue71

    Incorrect behaviour of default output directory on first run

commit df99aee
Author: philipstarkey <[email protected]>
Date:   Tue Jun 23 17:34:57 2020 +1000

    Incorrect behaviour of default output directory on first run
    Fixes #71

commit b007f3e
Author: philipstarkey <[email protected]>
Date:   Tue Jun 23 18:31:22 2020 +1000

    Fix #93: Can't restart subprocess
    Fixes #93

commit 3cf2808
Merge: 2613d48 cda516d
Author: Russell Anderson <[email protected]>
Date:   Mon Jun 22 18:08:55 2020 +1000

    Merge pull request #90 from philipstarkey/master

    Doc updates

commit cda516d
Author: philipstarkey <[email protected]>
Date:   Sat Jun 20 18:12:50 2020 +1000

    Doc updates

    Renamed API reference URL to match labscript utils and updated config to fix bugs identified in labscript-suite/labscript-utils#57

commit 2613d48
Merge: fbbdfa0 a27a239
Author: Phil Starkey <[email protected]>
Date:   Fri Jun 19 18:59:59 2020 +1000

    Merge pull request #89 from philipstarkey/master

    Initial commit of sphinx docs

commit a27a239
Author: philipstarkey <[email protected]>
Date:   Fri Jun 19 17:07:02 2020 +1000

    Fixed incorrect component used for version

commit 859a44d
Author: philipstarkey <[email protected]>
Date:   Fri Jun 19 16:00:13 2020 +1000

    Addressing latest review comments

commit 6c763e7
Author: philipstarkey <[email protected]>
Date:   Fri Jun 19 11:18:36 2020 +1000

    Added missing todolist directive on index page

commit 6466ff0
Author: philipstarkey <[email protected]>
Date:   Fri Jun 19 11:10:29 2020 +1000

    Updated docs to use jinja template for component doc links

commit 841840a
Author: philipstarkey <[email protected]>
Date:   Thu Jun 18 17:30:33 2020 +1000

    Initial commit of sphinx docs

commit fbbdfa0
Author: Russell Anderson <[email protected]>
Date:   Wed Jun 17 11:40:02 2020 +1000

    Populated README.md with styling, iconogrpahy, prose, and badges

commit ce96779
Merge: 7562830 a1e2462
Author: Russell Anderson <[email protected]>
Date:   Tue Jun 16 12:06:56 2020 +1000

    Merge pull request #88 from rpanderson/master

    experiment_name changed to apparatus_name

commit a1e2462
Author: Russell Anderson <[email protected]>
Date:   Wed Jun 10 22:52:20 2020 +1000

    experiment_name changed to apparatus_name

    Per labscript-suite/labscript-utils#53

Co-authored-by: chrisjbillington <[email protected]>
Co-authored-by: Russell Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipstarkey philipstarkey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Incorrect behaviour of default output directory on first run philipstarkey/runmanager
2 participants
@chrisjbillington @philipstarkey