Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run.get_* methods should open the HDF5 file in read-only mode #42

Closed
philipstarkey opened this issue Nov 5, 2018 · 0 comments · Fixed by #71
Closed

Run.get_* methods should open the HDF5 file in read-only mode #42

philipstarkey opened this issue Nov 5, 2018 · 0 comments · Fixed by #71
Labels
bug Something isn't working minor

Comments

@philipstarkey
Copy link
Member

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

All of the Run.get_* methods don't have a file mode specified, and this results in the file modified time changing whenever you access a shot file with them (even if you aren't doing any writing).

So we should add 'r' as the file mode to every h5py.File call within the Run.get_* methods
@philipstarkey philipstarkey added minor bug Something isn't working labels Apr 5, 2020
@philipstarkey philipstarkey mentioned this issue May 27, 2020
Closed
philipstarkey added a commit to philipstarkey/lyse that referenced this issue Jun 24, 2020
@philipstarkey
Run.get_* methods should open the HDF5 file in read-only mode
2d8a80e 
Fixes labscript-suite#42

Also addressed labscript-suite/labscript-utils#47 (removing h5py deprecation warnings) for this module

Also fixed an issue where calling `set_group` on a `Run` inside a `Sequence` could disable the read-only mode of the `Run` object.

Added `no_write` support to `Sequence`.
@philipstarkey philipstarkey mentioned this issue Jun 24, 2020
Merged
philipstarkey added a commit that referenced this issue Jun 25, 2020
@philipstarkey @chrisjbillington @rpanderson
Squashed commit of the following:
d9ad984 
commit f7a1427
Author: Phil Starkey <[email protected]>
Date:   Thu Jun 25 19:03:31 2020 +1000

    Update dependencies in setup.cfg

    Bumped runmanager and labscript_utils versions to `>=3.0.0`

commit 20cb9af
Merge: 74dfc19 2d8a80e
Author: Phil Starkey <[email protected]>
Date:   Thu Jun 25 12:56:40 2020 +1000

    Merge pull request #71 from philipstarkey/philipstarkey/issue42

commit 2d8a80e
Author: philipstarkey <[email protected]>
Date:   Wed Jun 24 19:22:04 2020 +1000

    Run.get_* methods should open the HDF5 file in read-only mode
    Fixes #42

    Also addressed labscript-suite/labscript-utils#47 (removing h5py deprecation warnings) for this module

    Also fixed an issue where calling `set_group` on a `Run` inside a `Sequence` could disable the read-only mode of the `Run` object.

    Added `no_write` support to `Sequence`.

commit 74dfc19
Merge: 1fc61cb 6cd5d06
Author: Russell Anderson <[email protected]>
Date:   Mon Jun 22 18:06:38 2020 +1000

    Merge pull request #70 from philipstarkey/master

    fix docs conf bugs identified in labscript-suite/labscript-utils#57

commit 6cd5d06
Author: philipstarkey <[email protected]>
Date:   Sat Jun 20 18:35:29 2020 +1000

    fix docs conf bugs identified in labscript-suite/labscript-utils#57

commit 1fc61cb
Merge: c6c2aa7 eed3f6e
Author: Phil Starkey <[email protected]>
Date:   Fri Jun 19 19:01:03 2020 +1000

    Merge pull request #69 from philipstarkey/master

    Empty sphinx project following our template

commit eed3f6e
Author: philipstarkey <[email protected]>
Date:   Fri Jun 19 18:30:22 2020 +1000

    Empty sphinx project following our template

commit c6c2aa7
Author: Russell Anderson <[email protected]>
Date:   Wed Jun 17 11:39:43 2020 +1000

    Populated README.md with styling, iconogrpahy, prose, and badges

commit 5760b8a
Merge: bb2061d 84c6ec7
Author: Russell Anderson <[email protected]>
Date:   Tue Jun 16 12:07:02 2020 +1000

    Merge pull request #68 from rpanderson/master

    experiment_name changed to apparatus_name

commit 84c6ec7
Author: Russell Anderson <[email protected]>
Date:   Wed Jun 10 22:54:44 2020 +1000

    experiment_name changed to apparatus_name

    Per labscript-suite/labscript-utils#53

Co-authored-by: chrisjbillington <[email protected]>
Co-authored-by: Russell Anderson <[email protected]>
Loki27182 pushed a commit to Loki27182/lyse that referenced this issue Oct 9, 2023
@chrisjbillington
Merge with PhyNerd/Analysis-loop-freez-fix (Pull request labscript-su…
3afbcbd 
…ite#42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run.get_* methods should open the HDF5 file in read-only mode philipstarkey/lyse
1 participant
@philipstarkey