Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pseudoclock wait_delay is probably not respected #50

Open
philipstarkey opened this issue Oct 30, 2018 · 0 comments
Open

pseudoclock wait_delay is probably not respected #50

philipstarkey opened this issue Oct 30, 2018 · 0 comments
Labels
bug Something isn't working major

Comments

@philipstarkey
Copy link
Member

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


As per the comment chain in this pull request over on the labscript_devices repository, I suspect that the wait_delay attribute of secondary pseudoclocks is not being respected, and thus the master pseudoclock may not wait a sufficient time before emitting a trigger pulse to resume the shot.

This would result in secondary pseudoclocks becoming out of sync with the primary, which may explain the occasional dropped shots seen in the monash spinor BEC lab.

We should check to see if it is easy to fix in labscript 2, or if we need to wait until labscript 3 in order to correctly offset instruction times for secondary pseudoclocks.

@philipstarkey philipstarkey added major bug Something isn't working labels Apr 5, 2020
Loki27182 pushed a commit to Loki27182/labscript that referenced this issue Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

1 participant