Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin Base-Classes #41

Open
philipstarkey opened this issue Apr 25, 2018 · 0 comments
Open

Plugin Base-Classes #41

philipstarkey opened this issue Apr 25, 2018 · 0 comments
Labels
minor proposal

Comments

@philipstarkey
Copy link
Member

Original report (archived issue) by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

There should be a base class for all plugin related classes:
Plugin, Notification and Settings

All plugin classes should inherit from these classes. That way new functionality can be added to the plugin system without breaking old plugins. It would also make it easier for someone new to the plugin system to understand which functions need to be implemented by a plugin.
Loki27182 pushed a commit to Loki27182/blacs that referenced this issue Oct 9, 2023
@chrisjbillington
Merged in cbillington/blacs/bugfix (pull request labscript-suite#41)
573193e 
Compile and restart fixes

Approved-by: Jan Werkmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philipstarkey