Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accountcenter merge #4795

Merged
merged 18 commits into from
Jul 12, 2024
Merged

Accountcenter merge #4795

merged 18 commits into from
Jul 12, 2024

Conversation

xudaotutou
Copy link
Contributor

No description provided.

feat(desktop): user merge:

feat(desktop): google unbinding

feat: add delete-user-log table

fix:fix proxy oauth login

fix:fix merge workorder

feat:add email bind

fix:fix hunger problem
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Jun 24, 2024

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1277
✅ Successful 377
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 899
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.45%. Comparing base (ef4409d) to head (d474a7d).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4795   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xudaotutou xudaotutou force-pushed the accountcenter-merge branch from 29d0d5a to ec7ca8c Compare July 10, 2024 11:29
@xudaotutou xudaotutou force-pushed the accountcenter-merge branch from ec7ca8c to 36b0fb1 Compare July 10, 2024 11:47
frontend/desktop/package.json Outdated Show resolved Hide resolved
return setPagestatus(PageStatus.REMAIN_OTHER_REGION_RESOURCE);
} else if (message === RESOURCE_STATUS.INSUFFICENT_BALANCE) {
return setPagestatus(PageStatus.INSUFFICIENT_BALANCE);
} else if (message === RESOURCE_STATUS.REMAIN_WORKSACE_OWNER) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

写个映射吧

const RESOURCE_STATUS_PAGE_MAP = {
[RESOURCE_STATUS.REMAIN_APP]: PageStatus.REMAIN_APP,
[RESOURCE_STATUS.REMAIN_DATABASE]: PageStatus.REMAIN_DATABASE,
[RESOURCE_STATUS.REMAIN_OBJECT_STORAGE]: PageStatus.REMAIN_OBJECT_STORAGE,
[RESOURCE_STATUS.REMAIN_TEMPLATE]: PageStatus.REMAIN_TEMPLATE,
[RESOURCE_STATUS.REMAIN_OTHER_REGION_RESOURCE]: PageStatus.REMAIN_OTHER_REGION_RESOURCE,
[RESOURCE_STATUS.INSUFFICENT_BALANCE]: PageStatus.INSUFFICIENT_BALANCE,
[RESOURCE_STATUS.REMAIN_WORKSACE_OWNER]: PageStatus.REMAIN_WORKSPACE
};

import { jsonRes } from '../response';
import { RESPONSE_MESSAGE } from '@/types/response/utils';

export const ErrorHandler =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个后续是不是可以改到中间件,不然每次都要写,这个方法应该通用的吧

if (!enableGoogle()) {
throw new Error('google svc is not defined');
}
await filterAccessToken(req, res, async ({ userUid }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种回调的写法,后续优化一下

@zzjin zzjin added this to the v5.0 milestone Jul 11, 2024
@zzjin zzjin merged commit 0853f2d into labring:main Jul 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants