Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(main): support crun youki gvisor kata #4189

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

cuisongliu
Copy link
Collaborator

@cuisongliu cuisongliu commented Oct 29, 2023

πŸ€– Generated by Copilot at 4bfeef0

Summary

βœ¨πŸ”§πŸ“š

Add support for multiple container runtimes in image-cri-shim. Update cri.go to handle a new Runtime type and read it from the config file.

Oh we are the image-cri-shim crew
And we have a job to do
We'll add some runtime options to the Config
On the count of one, two, three, pull!

Walkthrough

  • Define a new type Runtime to represent a container runtime configuration with fields for RuntimeType, RuntimeEngine, RuntimeRoot, and Options (link)
  • Modify the type Config to use the Runtime type for each of the the supported runtimes: Crun, Gvisor, Kata, Youki, and Runc, allowing different options for each runtime (link)
  • Update the logic of the processConfigFile function in cri.go to check the SystemdCgroup option for the default runtime name specified in the config file and return the correct cgroup driver (link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Oct 29, 2023

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 956
βœ… Successful 375
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 580
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 29, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@cuisongliu cuisongliu force-pushed the support_crun_youki branch 2 times, most recently from 3d42ffb to c231a49 Compare October 29, 2023 02:53
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

πŸ“’ Thoughts on this report? Let us know!.

@sealos-ci-robot
Copy link
Member

πŸ€– Generated by deploy action

πŸ‘€ Visit Preview

@cuisongliu cuisongliu merged commit 8476d81 into labring:main Oct 29, 2023
36 checks passed
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.4

@sealos-ci-robot
Copy link
Member

πŸ€– says: cherry pick action finished successfully πŸŽ‰!
See: https://github.com/labring/sealos/actions/runs/6682605727

cuisongliu added a commit that referenced this pull request Oct 29, 2023
sealos-ci-robot added a commit that referenced this pull request Oct 29, 2023
cuisongliu added a commit that referenced this pull request Oct 29, 2023
@cuisongliu cuisongliu deleted the support_crun_youki branch October 29, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants