-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(main): support crun youki gvisor kata #4189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sealos-ci-robot
added
area/imageCRIShim
about image-cri-shim
area/lifecycle-management
labels
Oct 29, 2023
π€ Generated by lychee actionSummary
Full action output |
Apply Sweep Rules to your PR?
|
cuisongliu
force-pushed
the
support_crun_youki
branch
2 times, most recently
from
October 29, 2023 02:53
3d42ffb
to
c231a49
Compare
Codecov ReportAll modified and coverable lines are covered by tests β π’ Thoughts on this report? Let us know!. |
π€ Generated by deploy action |
Signed-off-by: cuisongliu <[email protected]>
cuisongliu
force-pushed
the
support_crun_youki
branch
from
October 29, 2023 06:52
c231a49
to
606b115
Compare
bxy4543
approved these changes
Oct 29, 2023
/cherry-pick release-v4.4 |
π€ says: cherry pick action finished successfully π! |
sealos-ci-robot
pushed a commit
that referenced
this pull request
Oct 29, 2023
cuisongliu
added a commit
that referenced
this pull request
Oct 29, 2023
Co-authored-by: cuisongliu <[email protected]>
sealos-ci-robot
added a commit
that referenced
this pull request
Oct 29, 2023
Co-authored-by: cuisongliu <[email protected]>
cuisongliu
added a commit
that referenced
this pull request
Oct 29, 2023
Co-authored-by: cuisongliu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π€ Generated by Copilot at 4bfeef0
Summary
β¨π§π
Add support for multiple container runtimes in image-cri-shim. Update
cri.go
to handle a newRuntime
type and read it from the config file.Walkthrough
Runtime
to represent a container runtime configuration with fields forRuntimeType
,RuntimeEngine
,RuntimeRoot
, andOptions
(link)Config
to use theRuntime
type for each of the the supported runtimes:Crun
,Gvisor
,Kata
,Youki
, andRunc
, allowing different options for each runtime (link)processConfigFile
function incri.go
to check theSystemdCgroup
option for the default runtime name specified in the config file and return the correct cgroup driver (link)