This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Add lifetime to the distributed locks #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: Change TimeoutError to asyncio.TimeoutError
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 76.82% 76.93% +0.11%
==========================================
Files 26 26
Lines 3301 3317 +16
==========================================
+ Hits 2536 2552 +16
Misses 765 765
Continue to review full report at Codecov.
|
achimnol
commented
Apr 8, 2022
|
Let's skip the watchdog for |
2 tasks
achimnol
commented
Apr 12, 2022
src/ai/backend/common/lock.py
Outdated
| super().__init__(lifetime=lifetime) | ||
| self.lock_name = lock_name | ||
| self.etcd = etcd | ||
| self.lifetime = lifetime |
There was a problem hiding this comment.
There is self._lifetime inherited already. Please use it!
…://github.com/lablup/backend.ai-common into feature/add-lock-timeout-to-distributed-locks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will auto-release the locks if a manager process holding the lock hangs or abruptly killed in HA setup.
FileLockandPgAdvisoryLock(in the manager) auto-releases the lock when the manager process gets terminatedbecause the OS will close the relevant file descriptors.
EtcdLockrequires an explicit unlock and this may not release the lock in such cases.We could avoid this problem by adding an explicit lifetime that automatically releases the lock in the server-side.
Let's set the default lifetime to be
min(interval + 30, interval * 2)and implement:EtcdLock: lease-based lock lifetimeFileLock: add a watchdog task to auto-release the lock in case of hang