Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iam): Align IAM permissions with documentation #22

Merged
merged 1 commit into from
Nov 23, 2023
Merged

feat(iam): Align IAM permissions with documentation #22

merged 1 commit into from
Nov 23, 2023

Conversation

Balsir
Copy link
Contributor

@Balsir Balsir commented Nov 23, 2023 •
edited
Loading

Description

Align IAM permissions with permissions from the official documentation.
https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#full-cluster-autoscaler-features-policy-recommended

Type of change

  • A bug fix (PR prefix fix)
  • A new feature (PR prefix feat)
  • A code change that neither fixes a bug nor adds a feature (PR prefix refactor)
  • Adding missing tests or correcting existing tests (PR prefix test)
  • Changes that do not affect the meaning of the code like white-spaces, formatting, missing semi-colons, etc. (PR prefix style)
  • Changes to our CI configuration files and scripts (PR prefix ci)
  • Documentation only changes (PR prefix docs)

How Has This Been Tested?

Sandbox

@Balsir Balsir requested a review from dojci November 23, 2023 09:57
dojci
dojci approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@dojci dojci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Balsir Balsir merged commit 4183b0d into master Nov 23, 2023
5 checks passed
@Balsir Balsir deleted the feat/iam-permissions branch November 23, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dojci dojci dojci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Balsir @dojci