feat:add new support for permission boundry #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #18 |
bulka1
changed the title
|
@dojci Could you please have a look at this? |
katapultcloud
requested changes
Jan 24, 2024
| count = local.irsa_role_create ? 1 : 0 | ||
| name = "${var.irsa_role_name_prefix}-${var.helm_chart_name}" # tflint-ignore: aws_iam_role_invalid_name | ||
| assume_role_policy = data.aws_iam_policy_document.this_irsa[0].json | ||
| permissions_boundary = var.irsa_permissions_boundary |
There was a problem hiding this comment.
when permission boundary is empty tflint is failing. It needs to be ignore with the comment:
# tflint-ignore: aws_iam_role_invalid_permissions_boundary
| @@ -129,6 +129,12 @@ variable "irsa_tags" { | |||
| description = "IRSA resources tags" | |||
| } | |||
|
|
|||
| variable "irsa_permissions_boundary" { | |||
There was a problem hiding this comment.
when adding new variables make sure to run terraform-docs so README.md is adjusted along with the Terraform changes.
terraform-docs markdown table --output-file README.md --output-mode inject .
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a an option to add a permission boundary policy when creating the irsa rule
Type of change
fix)feat)refactor)test)style)ci)docs)How Has This Been Tested?