Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: align addon with latest template #17

Merged
merged 1 commit into from
Sep 15, 2023
Merged

feat: align addon with latest template #17

merged 1 commit into from
Sep 15, 2023

Conversation

jaygridley
Copy link
Member

Description

Type of change

  • A bug fix (PR prefix fix)
  • A new feature (PR prefix feat)
  • A code change that neither fixes a bug nor adds a feature (PR prefix refactor)
  • Adding missing tests or correcting existing tests (PR prefix test)
  • Changes that do not affect the meaning of the code like white-spaces, formatting, missing semi-colons, etc. (PR prefix style)
  • Changes to our CI configuration files and scripts (PR prefix ci)
  • Documentation only changes (PR prefix docs)

How Has This Been Tested?

  • Addons test suite, compared ArgoCD diff, no change

@jaygridley jaygridley requested a review from dojci August 29, 2023 17:18
@jaygridley jaygridley self-assigned this Aug 29, 2023
dojci
dojci approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@dojci dojci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaygridley jaygridley merged commit 8b113d9 into master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dojci dojci dojci approved these changes

Assignees

@jaygridley jaygridley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Allow replacement of default iam policy
2 participants
@jaygridley @dojci