Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jvojtek/module refactor #12

Merged
merged 16 commits into from
Jul 1, 2022
Merged

Jvojtek/module refactor #12

merged 16 commits into from
Jul 1, 2022

Conversation

JaroVojtek
Copy link
Contributor

No description provided.

@JaroVojtek JaroVojtek requested review from dojci and martinhaus April 29, 2022 13:59
@JaroVojtek JaroVojtek self-assigned this Apr 29, 2022
@JaroVojtek JaroVojtek marked this pull request as ready for review June 22, 2022 21:30
dojci
dojci requested changes Jun 29, 2022
View reviewed changes
Copy link
Member

@dojci dojci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update examples and add test matrix with all possible installation paths: helm, helm + argo, argo

variables.tf Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@JaroVojtek
Copy link
Contributor Author

tests added in basic/examples

dojci
dojci requested changes Jul 1, 2022
View reviewed changes
commitlint.config.js Outdated Show resolved Hide resolved
@dojci dojci merged commit 7c330eb into master Jul 1, 2022
@dojci dojci mentioned this pull request Jul 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dojci dojci dojci approved these changes

@martinhaus martinhaus Awaiting requested review from martinhaus

Assignees

@JaroVojtek JaroVojtek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaroVojtek @dojci