Fix RKE2 binary path check #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jLemmings thanks for the PR. Could you please resolve the conflicts? |
|
@MonolithProjects fixed the new merge conflicts. |
Fix/fix partition rke2
MonolithProjects
requested changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When upgrading a RKE2 cluster which either /usr/local is its own partition or its not writeable then it fails to use the rke2 binary. A similar fix has been made before for the hardening part. This PR moves the partition check to an earlier step and uses the information deciding where the binary is located.
Type of change
How Has This Been Tested?
Locally