adding option to disable builtin cloud controller #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonolithProjects
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Hi, could you please fix trailing whitespaces? The rest looks fine to me. https://github.com/lablabs/ansible-role-rke2/actions/runs/8178960201/job/22516426622?pr=202
|
@MonolithProjects done |
mueller-ma
reviewed
Apr 8, 2024
|
|
||
| # Cloud provider to use for the cluster (aws, azure, gce, openstack, vsphere, external) | ||
| # applicable only if rke2_disable_cloud_controller is true | ||
| rke2_cloud_provider_name: "rke2" |
There was a problem hiding this comment.
According to the comment above rke2 isn't a valid argument. defaults/main.yml uses external.
mueller-ma
added a commit
to mueller-ma/ansible-role-rke2
that referenced
this pull request
May 14, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
option to disable built-in cloud controller to deploy different cloud controller mostly for on prem and talos CCM
Type of change
How Has This Been Tested?
on my own clusters