Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update links and add the example to specify the address to advertise #184

Merged
merged 1 commit into from
Dec 17, 2023
Merged

update links and add the example to specify the address to advertise #184

merged 1 commit into from
Dec 17, 2023

Conversation

hoangphuocbk
Copy link
Contributor

@hoangphuocbk hoangphuocbk commented Dec 17, 2023 •
edited
Loading

Description

Type of change

  • Update links in README.md and defaults/main.yml
  • Give the example to mention the option node-id, which IPv4/IPv6 addresses to advertise for node. This option will help newcomer when host have many interfaces/addresses.

@MonolithProjects MonolithProjects self-assigned this Dec 17, 2023
@MonolithProjects MonolithProjects added the documentation Improvements or additions to documentation label Dec 17, 2023
MonolithProjects
MonolithProjects approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@MonolithProjects MonolithProjects merged commit 2402f21 into lablabs:main Dec 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonolithProjects MonolithProjects MonolithProjects approved these changes

Assignees

@MonolithProjects MonolithProjects

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoangphuocbk @MonolithProjects