Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change registry deployment so it works more intuitive and out of the box #151

Merged

Conversation

MichaelTrip
Copy link
Contributor

@MichaelTrip MichaelTrip commented Jun 5, 2023

Description

When i was configuring a custom registry i noticed that the config for the mirror was enabled by default. But in my case i don't need the mirroring option. I changed the role so those two can be deployed separately.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

For the test i overwrited the two variables in group_vars:

rke2_custom_registry_mirrors: []

rke2_custom_registry_configs:
  - endpoint: gitlab.domain.internal:5678
    config:
      auth:
        username: kubernetes
        password: kubernetes-password

I have tested this and it works. It creates this registries.yaml:

configs:
  gitlab.domain.internal:5678
    auth:
        username: kubernetes
        password: kubernetes-password

@MonolithProjects MonolithProjects self-assigned this Jun 16, 2023
@MonolithProjects MonolithProjects added the enhancement New feature or request label Jun 16, 2023
Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MonolithProjects MonolithProjects merged commit b3af10f into lablabs:main Jun 16, 2023
@MichaelTrip MichaelTrip deleted the change-registry-deployment branch June 19, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants