Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: issues defining custom registry configs after cluster creation #142

Closed
moray95 opened this issue Apr 20, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@moray95
Copy link

moray95 commented Apr 20, 2023

Summary

Custom registry configs doesn't work without defining a mirror and manually restarting rke2-agent on all nodes.

Issue Type

Bug Report

Ansible Version

ansible [core 2.14.4]
  config file = /Users/moray/.ansible.cfg
  configured module search path = ['/Users/moray/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /opt/homebrew/Cellar/ansible/7.4.0/libexec/lib/python3.11/site-packages/ansible
  ansible collection location = /Users/moray/.ansible/collections:/usr/share/ansible/collections
  executable location = /opt/homebrew/bin/ansible
  python version = 3.11.3 (main, Apr  7 2023, 20:13:31) [Clang 14.0.0 (clang-1400.0.29.202)] (/opt/homebrew/Cellar/ansible/7.4.0/libexec/bin/python3.11)
  jinja version = 3.1.2
  libyaml = True

Steps to Reproduce

  1. Set up a RKE2 cluster without any registry mirrors or configs.
  2. Add a registry config to the existing cluster and rerun the playbook
    rke2_custom_registry_configs:
      - endpoint: registry.example.com
        config:
          auth:
            username: "REDACTED"
            password: "REDACTED"
  1. Add a registry mirror to the existing cluster and rerun the playbook
    rke2_custom_registry_mirrors:
      - name: dummy.example.com
        endpoint:
          - https://dummy.example.com
    rke2_custom_registry_configs:
      - endpoint: registry.example.com
        config:
          auth:
            username: "REDACTED"
            password: "REDACTED"
  1. Restart rke2-agent on all nodes

Expected Results

Stopping at step 2 should be enough to update the registry configuration.

Actual Results

- Stopping at step 2 doesn't update the registry configs
- Stopping at step 3 produces 401 errors from the registry on image pull
@moray95 moray95 added the bug Something isn't working label Apr 20, 2023
@viq
Copy link
Contributor

viq commented May 17, 2023

#149 should take care of restarting the agent.

Niro added a commit to Niro/ansible-role-rke2 that referenced this issue Jul 19, 2023
MonolithProjects added a commit that referenced this issue Aug 18, 2023
#142 Typo fix in parameter name for custom registry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants