docker: move to Docker compose v2 #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version is now an obsolete element [1]. [1] https://docs.docker.com/compose/compose-file/04-version-and-name/#version-top-level-element-optional Signed-off-by: Bastian Krause <[email protected]>
Docker compose v1 has been deprecated since July 2023 [1]. Now the GitHub actions Ubuntu runner images removed it, too [2]. So move to v2. labgrid is obviously not affected by any changes between v1 and v2 other than the compose call docker-compose -> docker compose. [1] https://docs.docker.com/compose/migrate/ [2] actions/runner-images#9692 Signed-off-by: Bastian Krause <[email protected]>
jluebbe
approved these changes
Aug 6, 2024
|
LGTM! |
|
Thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Docker compose v1 has been deprecated since July 2023 [1]. Now the GitHub actions Ubuntu runner images removed it, too [2]. So move to v2.
labgrid is obviously not affected by any changes between v1 and v2 other than the compose call
docker-compose->docker compose.While at it, drop the obsolete version element [3] from the docker compose config.
[1] https://docs.docker.com/compose/migrate/
[2] actions/runner-images#9692
[3] https://docs.docker.com/compose/compose-file/04-version-and-name/#version-top-level-element-optional
Checklist