target: improve exceptions #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labgrid's exceptions are already hard to understand, so at least use the short-hand version of the class name in the error messages. Example: NoDriverFoundError: multiple drivers matching <class 'labgrid.protocol.consoleprotocol.ConsoleProtocol'> found in Target(name='main', env=Environment(config_file='env.yaml')) with the same priorities ..becomes.. NoDriverFoundError: multiple drivers matching ConsoleProtocol found in Target(name='main', env=Environment(config_file='env.yaml')) with the same priorities Signed-off-by: Bastian Krause <[email protected]>
NoSupplierFoundError and its sub classes are hard to understand if the driver/strategy causing it is not mentioned: NoDriverFoundError: multiple drivers matching ConsoleProtocol found in Target(name='main', env=Environment(config_file='env.yaml')) with the same priorities Improve this by rasing a more detailed exception from the original exception with this information included: NoDriverFoundError: binding MyStrategy failed: multiple drivers matching ConsoleProtocol found in Target(name='main', env=Environment(config_file='env.yaml')) with the same priorities Signed-off-by: Bastian Krause <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1270 +/- ##
======================================
Coverage 63.0% 63.0%
======================================
Files 160 160
Lines 11848 11851 +3
======================================
+ Hits 7472 7476 +4
+ Misses 4376 4375 -1
☔ View full report in Codecov by Sentry. |
Emantor
approved these changes
Sep 18, 2023
cruise-bryan-murdock
approved these changes
Sep 20, 2023
|
Since this changes the exception string only and the PR is open for a while now, I'll merge this without second approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use short-hand class names and add driver causing
NoSupplierFoundErrorsin error messages.Checklist