Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Flush): add new flush method for Android/iOS #9

Merged
merged 5 commits into from
Jan 28, 2022
Merged

feat(Flush): add new flush method for Android/iOS #9

merged 5 commits into from
Jan 28, 2022

Conversation

danielgomezrico
Copy link
Contributor

If you are in debug mode, been able to flush events, It's pretty helpful.

Currently, this is not allowed

Docs

@danielgomezrico danielgomezrico marked this pull request as draft January 27, 2022 18:31
cdmunoz
cdmunoz approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@cdmunoz cdmunoz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

One question: this is still a work inn progress? The PR is in Draft state.

@danielgomezrico danielgomezrico marked this pull request as ready for review January 28, 2022 14:34
juansoos
juansoos approved these changes Jan 28, 2022
View reviewed changes
Copy link

@juansoos juansoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍🏻

Santi92
Santi92 approved these changes Jan 28, 2022
View reviewed changes
Copy link

@Santi92 Santi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@danielgomezrico danielgomezrico merged commit 974398b into master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santi92 Santi92 Santi92 approved these changes

@juansoos juansoos juansoos approved these changes

@cdmunoz cdmunoz cdmunoz approved these changes

@julianjab julianjab Awaiting requested review from julianjab

@sicodelicos2003 sicodelicos2003 Awaiting requested review from sicodelicos2003

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielgomezrico @cdmunoz @juansoos @Santi92