-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ansible galaxy v3 compatibility #24
base: master
Are you sure you want to change the base?
Feature/ansible galaxy v3 compatibility #24
Conversation
…bility-interim Feature/ansible galaxy v3 compatibility interim
@l3ender : When do you think you can integrate this fix into a next release? |
@l3ender : When do you think you can integrate this fix into a next release? |
Thanks for this PR! My apologies for missing it the first time around. I've noticed your recent activity, so please tag me when it's ready to go. Thanks again! |
I updated the PR in order to support GitHub actions and release the new version simply tagging the code with version (eg. v0.3.3). Once released, we have to update again the code in order to built with Java 17 and support Nexus 3.69+ (https://help.sonatype.com/en/sonatype-nexus-repository-system-requirements.html) and check if works properly with PostgreSQL because embedded OrientDB (which I used to test the plugin, version 3.68.0) is no longer supported.
Once merged we can close this issue and check if further changes are needed. Readme was updated with reference to "this" version (0.3.3) and marked 0.4.x as TBD. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this PR and the work in it!
I like the thought of using workflows/actions for a validate/release pipeline (less manual work), but is it possible to keep those changes in a separate PR?
Other than that, the changes look good and I'm good to proceed with merge/release of the update. Please note that I didn't run/test these locally.
Thanks again!
Implemented compatibility with ansible galaxy v3
This pull request makes the following changes:
It relates to the following issue:
cc @DarthHater @bhamail @l3ender