Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ansible galaxy v3 compatibility #24

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

angeloxx
Copy link

@angeloxx angeloxx commented Nov 5, 2023

Implemented compatibility with ansible galaxy v3

This pull request makes the following changes:

  • add support to v3 api for collection
  • backward compatibility with older ansible engine, converting api from v2 to v3

It relates to the following issue:

cc @DarthHater @bhamail @l3ender

@lamm
Copy link

lamm commented Jan 11, 2024

@l3ender : When do you think you can integrate this fix into a next release?

@cniweb
Copy link

cniweb commented Feb 29, 2024

@l3ender : When do you think you can integrate this fix into a next release?

@l3ender
Copy link
Owner

l3ender commented Sep 2, 2024

Thanks for this PR! My apologies for missing it the first time around.

I've noticed your recent activity, so please tag me when it's ready to go. Thanks again!

@angeloxx
Copy link
Author

angeloxx commented Sep 2, 2024

I updated the PR in order to support GitHub actions and release the new version simply tagging the code with version (eg. v0.3.3). Once released, we have to update again the code in order to built with Java 17 and support Nexus 3.69+ (https://help.sonatype.com/en/sonatype-nexus-repository-system-requirements.html) and check if works properly with PostgreSQL because embedded OrientDB (which I used to test the plugin, version 3.68.0) is no longer supported.

Nexus Repository no longer supports OrientDB, Java 8, or Java 11 in future releases. OrientDB users must migrate to H2 or PostgreSQL before upgrading to version 3.71.0

Once merged we can close this issue and check if further changes are needed. Readme was updated with reference to "this" version (0.3.3) and marked 0.4.x as TBD.

Copy link
Owner

@l3ender l3ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this PR and the work in it!

I like the thought of using workflows/actions for a validate/release pipeline (less manual work), but is it possible to keep those changes in a separate PR?

Other than that, the changes look good and I'm good to proceed with merge/release of the update. Please note that I didn't run/test these locally.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install collection from new Galaxy
5 participants