-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for OTEL Collector #106
Conversation
If the end user makes changes to the endpoint field in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add other architure support (i.e. arm).
We are getting this error 024-05-06T12:04:52.044+0530 error exporterhelper/queue_sender.go:101 Exporting failed. Dropping data. {"kind": "exporter", "data_type": "metrics", "name": "prometheusremotewrite", "error": "Permanent error: Permanent error: context deadline exceeded", "dropped_items": 39} go.opentelemetry.io/collector/exporter/exporterhelper.newQueueSender.func1
So the OTEL collector works fine in x64 architecture right? |
This issue is not yet fixed by OTEL. But there is a workaround: open-telemetry/opentelemetry-collector-contrib#31910 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exporting to Otel_collector should not default, make it conditional please
Please update the setup steps in the README file. |
Hi @sanfern! Made changes as per review comments. Let me know if further changes are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor changes needed, by removing else block.
dev_environment/config.yaml
Outdated
@@ -7,4 +7,5 @@ configs: | |||
host_l3af_debug_port: '38899' | |||
host_l3afd_code_dir: '/code/l3afd' | |||
traffic_mirroring: 'false' | |||
host_distro_codename: 'jammy' | |||
otel_collector: 'false' | |||
host_distro_codename: 'jammy' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove newline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Roopesh Saravanan <[email protected]>
Signed-off-by: Roopesh Saravanan <[email protected]>
Signed-off-by: Roopesh Saravanan <[email protected]>
Signed-off-by: Roopesh Saravanan <[email protected]>
Signed-off-by: Roopesh Saravanan <[email protected]>
Signed-off-by: Roopesh Saravanan <[email protected]>
Signed-off-by: Roopesh Saravanan <[email protected]>
Signed-off-by: Roopesh Saravanan <[email protected]>
497514b
to
9a522e8
Compare
No additional instrumentation changes are required for the OTEL collector. It receives (supports prometheus metrics format) metrics from Prometheus and exports them to the desired remote backend. I also tested OTEL collector with Grafana cloud.
#105