This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Various Small Improvements #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The were two problems with the old name “fish shell”: 1. The name was not titlecased as recommended by the bundle style guidelines [1]. 2. Fish is already short for “Friendly Interactive Shell” [2], therefore the additional “shell” is a little bit redundant :). [1]: http://wiki.macromates.com/Bundles/StyleGuide [2]: https://en.wikipedia.org/wiki/Friendly_interactive_shell
- We now also provide installation instructions for TextMate 2. - This change also updates the link to the homepage of the fish project.
We did this, since most of the other bundles use this convention too. #ignore
Before this change the bundle grammar incorrectly considered variables such as `$__why` to be two different items: The special variable `$_` followed by the item `_why`. This commit fixes the first part of issue l15n#2.
Before this change the bundle grammar would not correctly match items starting with escaped characters. This fixes l15n#2.
The new command “Reformat Document” reformats the current document using Fish’s Indent function (`fish_indent`).
|
@l15n could you review this PR? Is this repo alive at all? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Leonard,
thank you for this great bundle. The following pull request contains minor small improvements. Most importantly, it fixes two small problems with the language grammar mentioned in issue #2:
If I should change anything for this to get merged, then please comment below.
Thanks,
René