[Feature] Add Karpenter Do Not Disrupt policy for Karpenter 1.x migration #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion This policy adds the karpenter.sh/do-not-disrupt label to pods that have the deprecated karpenter.sh/do-not-evict label to ensure smooth upgrades from Karpenter 0.x to 1.x versions. Fixes kyverno#1191 Signed-off-by: Indrranil Pawar <[email protected]>
Added chainsaw and kyverno test files to verify policy behavior for: - Label mutation from do-not-evict to do-not-disrupt - Proper handling of pods with and without the original label - Policy readiness verification Signed-off-by: Indrranil Pawar <[email protected]>
Signed-off-by: Indrranil Pawar <[email protected]>
realshuting
reviewed
Dec 18, 2024
|
Hi @jkannan-talend - can you please help with the review? |
realshuting
approved these changes
Dec 20, 2024
Kindly ping @jkannan-talend ⬆️ |
|
Hi @jkannan-talend could you take a look at this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature] Add Karpenter Do Not Disrupt policy for Karpenter 1.x migration
This policy adds the karpenter.sh/do-not-disrupt label to pods that have the deprecated karpenter.sh/do-not-evict label to ensure smooth upgrades from Karpenter 0.x to 1.x versions.
Fixes #1191
Related Issue(s)
Description
This PR:
karpenter.sh/do-not-disruptlabel to pods having the deprecatedkarpenter.sh/do-not-evictlabelChecklist