-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chainsaw Tests] Add Chainsaw test for Bare Pods #1057
Conversation
…ponding clusterrole definition for the test Signed-off-by: Jay179-sudo <[email protected]>
Maybe we can also reduce the scheduled time on the ClusterCleanupPolicy file from five minutes down to one minute to reduce CI time? |
Makes sense, can you replicate the same policy and reduce the scheduled time to a minute? |
Signed-off-by: Jay179-sudo <[email protected]>
… changes to the original policy Signed-off-by: Jay179-sudo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the ClusterRole inside the .chainsaw-test
directory.
cleanup/cleanup-bare-pods/.chainsaw-test/cleanup-bare-pods-test.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Chip Zoller <[email protected]>
Signed-off-by: Chip Zoller <[email protected]>
…scheduled time Signed-off-by: Jay179-sudo <[email protected]>
@chipzoller any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Jay179-sudo! 💪 Left some nit comments...
Signed-off-by: Jay179-sudo <[email protected]>
e18ce24
to
2a515a1
Compare
Signed-off-by: Jay179-sudo <[email protected]>
Related Issue(s)
Partial fix for #950
Description
Added chainsaw test for bare pods. Also added a test pod and a cluster-role manifest file.
Checklist