Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Hopefully) Fix Win11 Compatibility #26

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

Sprixitite
Copy link
Contributor

Should fix issues with the System.Windows.Forms DLL not loading on Windows 11 according to issue #24, this doesn't seem to revert linux functionality (in my limited testing of "does it compile?")

Should fix issues with the `System.Windows.Forms` DLL not loading on Windows 11 according to issue kythyria#24, this doesn't seem to revert linux functionality (in my limited testing of "does it compile?")
@ghost
Copy link

ghost commented Feb 12, 2023

It appears I'm still unable to open the program, and I am still getting the same error D:

Unhandled exception. System.IO.FileLoadException: Could not load file or assembly 'System.Windows.Forms, Version=6.0.2.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'. The located assembly's manifest definition does not match the assembly reference. (0x80131040)
File name: 'System.Windows.Forms, Version=6.0.2.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'
   at PD2ModelParser.Program.Main(String[] args)

@Sprixitite
Copy link
Contributor Author

I assume you already have it installed but could you please run the installer found at this link just to double check you have the .net 6 runtime installed? https://dotnet.microsoft.com/en-us/download/dotnet/6.0

@Sprixitite
Copy link
Contributor Author

Another thing to note is that those compiling under Linux (without the use of wine) will now need to set the flag "--runtime win10-x64" or the program will try to resolve for the Linux version of the Windows Desktop Runtime (which obviously doesn't exist)

I'm unsure if this classifies as a regression or not however, as I'm not sure cross-compilation was possible at all before the use of these csproj changes (once again without the use of wine)

@ghost
Copy link

ghost commented Feb 18, 2023

It appears the error was on my end, as I simply forgot to install .net 6 runtime :(
All seems to be working great now.

@Sprixitite
Copy link
Contributor Author

Unfortunate, glad I could help though.

Still asking this be pushed provided it doesn't regress windows compatibility, it (at least on Linux) only seems to be a step forward

Thanks

@kythyria kythyria merged commit 48d24ab into kythyria:master Mar 16, 2023
@Sprixitite Sprixitite deleted the patch-2 branch March 19, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants