feat(tag): colour token updates #310
Conversation
✅ Deploy Preview for shidoka-applications ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Waiting for response from design team regarding the color when Tag is in pressed state. |
| * Shade `'light'` (default) and `'dark'` for tag. | ||
| */ | ||
| @property({ type: String }) | ||
| shade = 'light'; |
There was a problem hiding this comment.
We're removing shade variants? Might want to note that as a soft breaking change.
There was a problem hiding this comment.
yes, we thought of removing it since it is changing already as part of the light and dark theme. Will make a note of it.
There was a problem hiding this comment.
Verified the Tag colors in dark mode
Verified the Tag group in dark mode
Verified the Clickable Tags
Verified Disable Tag color and looks fine
@jaideep08 , observed that close button boarder is bit thicker than Figma.! you can proceed if it's fine from backend.
@srpriyankashetty, fixed it. |
|
🎉 This PR is included in version 2.0.0-next.40 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Tag component
ADO Story or GitHub Issue Link
TASK 2003572
Figma Link
Tag component
Checklist
analyzecommand to update Storybook docs.testlocally to address any failures.