Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio button): disable radio button #295

Merged
merged 6 commits into from
Dec 13, 2024
Merged

fix(radio button): disable radio button #295

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6c6a5a4
fix(radio button): disable radio button
Dec 11, 2024
b23d4bd
fix: _handleSlotChange for radioButtonGroup
Dec 11, 2024
bdebcb4
fix: removed requestUpdate
Dec 12, 2024
2c36d65
fix: call _updateChildren from _handleSlotChange and updated
Dec 12, 2024
bb9cd35
docs: fix to connect hideCancelButton control in modal
Dec 12, 2024
b3ac883
Merge branch 'main' into radiobutton-fix
tulasigudibanda Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/components/reusable/radioButton/radioButtonGroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,24 @@ export class RadioButtonGroup extends FormMixin(LitElement) {
: null}

<div class="${this.horizontal ? 'horizontal' : ''}">
<slot></slot>
<slot @slotchange=${this._handleSlotChange}></slot>
</div>
</fieldset>
`;
}

private _handleSlotChange() {
this._updateChildren();
this.requestUpdate();
tulasigudibanda marked this conversation as resolved.
Show resolved Hide resolved
}

private _updateChildren() {
tulasigudibanda marked this conversation as resolved.
Show resolved Hide resolved
this.radioButtons.forEach((radioButton) => {
radioButton.disabled = this.disabled;
radioButton.checked = this.value.includes(radioButton.value);
});
}

override willUpdate(changedProps: any) {
if (changedProps.has('textStrings')) {
this._textStrings = deepmerge(_defaultTextStrings, this.textStrings);
Expand Down
Loading