-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(date time picker): dark mode token updates #279
Conversation
…cations into next
…cations into next
…cations into next
…cations into next
…cations into next
…cations into next
…cations into next
✅ Deploy Preview for shidoka-applications ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…cations into next
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a couple small comments but LGTM overall.
…cations into next
@srpriyankashetty fixed two bugs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the Date range, Date + time range in dark mode and looks fine
Verified the Single date, Date + time Hindi locale and Multiple date selection looks fine in dark mode
Verified the Default time, Time picker(24hr) and Japanese locale example in dark mode and looks fine.
Verified the Pattern/Forms showing the same changes as per the main component in dark mode theme.
Verified the issues mentioned:
Multiple date selection - Clear button is now showing as calendar when cleared
In all the date and time pickers - the calendar pop-up now disappears on enabling disable date or time picker.
🎉 This PR is included in version 2.0.0-next.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
ADO Story or GitHub Issue Link
Figma Link
Date Picker/ Time Picker/Date and Time Picker
Notes
--kd-color-date-and-time-picker-*
)Checklist
analyze
command to update Storybook docs.test
locally to address any failures.Screenshots