Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date time picker): dark mode token updates #279

Merged
merged 30 commits into from
Dec 3, 2024

Conversation

wbarbee
Copy link
Contributor

@wbarbee wbarbee commented Nov 26, 2024

Summary

  • Flatpickr theme
  • Date Picker
  • Date Range Picker
  • Time Picker

ADO Story or GitHub Issue Link

Figma Link

Date Picker/ Time Picker/Date and Time Picker

Notes

  • UX added Date and Time Picker specific tokens (--kd-color-date-and-time-picker-*)
  • divider between two range calendars is not currently possible, given the foundational flatpickr html structure

Checklist

  • Used Conventional Commit messages as outlined in the contributing guide.
    • Noted breaking changes (if any).
  • Documented/updated all props, events, slots, parts, etc with JSDoc.
    • Ran the analyze command to update Storybook docs.
  • Added/updated Stories with controls to cover all variants.
  • Ran test locally to address any failures.
  • Added/updated the Figma link for the Story's Design tab.
  • Added any new component exports to the src/index.ts file

Screenshots

Screenshot 2024-12-02 at 1 06 12 PM Screenshot 2024-12-02 at 1 06 22 PM Screenshot 2024-12-02 at 1 06 43 PM Screenshot 2024-12-02 at 1 15 44 PM Screenshot 2024-12-02 at 1 08 06 PM Screenshot 2024-12-02 at 1 11 10 PM Screenshot 2024-12-02 at 1 11 18 PM

@wbarbee wbarbee changed the base branch from main to next November 26, 2024 16:39
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for shidoka-applications ready!

Name Link
🔨 Latest commit 5f3553b
🔍 Latest deploy log https://app.netlify.com/sites/shidoka-applications/deploys/674f352385d0bc0008591efd
😎 Deploy Preview https://deploy-preview-279--shidoka-applications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wbarbee wbarbee changed the title Feat/date time picker dark mode feat(date time picker): dark mode updates Nov 26, 2024
@wbarbee wbarbee requested review from a team December 2, 2024 19:18
@wbarbee wbarbee marked this pull request as ready for review December 2, 2024 19:19
Copy link
Contributor

@brian-patrick-3 brian-patrick-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple small comments but LGTM overall.

src/components/reusable/datePicker/datepicker.ts Outdated Show resolved Hide resolved
src/common/scss/shidoka-flatpickr-theme.scss Outdated Show resolved Hide resolved
@wbarbee wbarbee changed the title feat(date time picker): dark mode updates fix(date time picker): dark mode token updates Dec 3, 2024
@wbarbee
Copy link
Contributor Author

wbarbee commented Dec 3, 2024

@srpriyankashetty fixed two bugs:

  1. edge case 1: multiple datepicker selection clear button now resets to the calendar icon when multiple selections are selected then cleared
  2. edge case 2: for date/date range/time pickers, we are now detecting changes to the disable form input property and closing the flatpickr selector so that the dev/user is not able to select dates once disabled

Copy link

@srpriyankashetty srpriyankashetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the Date range, Date + time range in dark mode and looks fine
Verified the Single date, Date + time Hindi locale and Multiple date selection looks fine in dark mode
Verified the Default time, Time picker(24hr) and Japanese locale example in dark mode and looks fine.
Verified the Pattern/Forms showing the same changes as per the main component in dark mode theme.
Verified the issues mentioned:
Multiple date selection - Clear button is now showing as calendar when cleared
In all the date and time pickers - the calendar pop-up now disappears on enabling disable date or time picker.

@wbarbee wbarbee merged commit 1f1e776 into next Dec 3, 2024
9 checks passed
@wbarbee wbarbee deleted the feat/date-time-picker-dark-mode branch December 3, 2024 16:49
@brian-patrick-3
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants