-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(form components): dark mode token updates #277
Conversation
…cations into next
…cations into next
…cations into next
…cations into next
…cations into next
✅ Deploy Preview for shidoka-applications ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…cations into next
…cations into next
Hi @wbarbee ,
|
thanks! |
same thing here @srpriyankashetty. those are instances of the Tag component that will be styled correctly once those changes are merged in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified Checkbox, Checkbox group and Checkbox subgroup looks fine in dark mode theme.
Verified Single, Single searchable, Multi select, Multi select searchable, Grouped and Data driven options dropdown looks fine in dark mode theme.
Verified the Number input in dark mode and looks fine
Verified the Toggle button in dark mode and looks fine.
Verified Text input and text input with icon in dark mode theme and looks fine.
Verified that Text Area looks fine in Dark mode theme.
Verified the Radio button and Radio button group in dark mode theme.
@wbarbee .
Just need clarification on the color of Radio button in dark mode - is this expected color?
The look and feel wise i feel its better if we have some lighter color.!
confirmed that this token, |
🎉 This PR is included in version 2.0.0-next.21 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Implement Dark Mode color tokens from updated Figma files for 2.0 Breaking Changes on the following components:
Checkbox -- (* check after Robert's new tokens are updated, may need to update checked base tokens)
Radio Button -- (* check after Robert's new tokens are updated)
Text Input
Text Area
Toggle Button
Dropdown -- (* check tags when tokens updated)
Number Input (* check +/- when button tokens updated)
Form Label
form-input.scss
* (base styles for most form input components) -- check WARNING, check whether disabled labels should have stylingForm components that will be handled on a separate PR:
ADO Story or GitHub Issue Link
Figma Links
Checklist
analyze
command to update Storybook docs.test
locally to address any failures.Figma/Storybook Inconsistencies
thumb color on toggleButton hover in dark mode (--kd-color-background-ui-hollow-default
):Background/UI/Default/Secondary
(--kd-color-background-ui-default-secondary
) -- not available in storybook/tokens
(push requested from design team)Background/Container/Default
(--kd-color-background-container-default
) doesn't match figmaTesting Instructions
Patterns/Forms
storyScreenshots
(if any)