Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio button): disable radio button #295

Merged
merged 6 commits into from
Dec 13, 2024
Merged

fix(radio button): disable radio button #295

merged 6 commits into from
Dec 13, 2024

Conversation

tulasigudibanda
Copy link
Contributor

ADO Story or GitHub Issue Link

#292

@netlify Netlify
Copy link

netlify bot commented Dec 11, 2024 •
edited
Loading

✅ Deploy Preview for shidoka-applications ready!

Name Link
🔨 Latest commit b3ac883
🔍 Latest deploy log https://app.netlify.com/sites/shidoka-applications/deploys/675b4712fdb1340008c441a6
😎 Deploy Preview https://deploy-preview-295--shidoka-applications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brian-patrick-3 brian-patrick-3 linked an issue Dec 11, 2024 that may be closed by this pull request
Radio button component – Button and label are not grayed out when disabled #292
Closed
1 task
brian-patrick-3
brian-patrick-3 requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@brian-patrick-3 brian-patrick-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing radio buttons in the group appearing as enabled on load when the disabled flag is true.

I think the actual fix will be to use slotchange event to sync the properties of the group with the child radio buttons. Checkbox group was set up that way, I think radio button never got that treatment.

@tulasigudibanda
Copy link
Contributor Author

I'm still seeing radio buttons in the group appearing as enabled on load when the disabled flag is true.

I think the actual fix will be to use slotchange event to sync the properties of the group with the child radio buttons. Checkbox group was set up that way, I think radio button never got that treatment.

Pushed the slotchange fix

srpriyankashetty
srpriyankashetty approved these changes Dec 13, 2024
View reviewed changes
Copy link

@srpriyankashetty srpriyankashetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and looks fine

image
Uploading image.png…

@tulasigudibanda tulasigudibanda merged commit b14ea29 into main Dec 13, 2024
9 checks passed
@tulasigudibanda tulasigudibanda deleted the radiobutton-fix branch December 13, 2024 14:31
@brian-patrick-3
Copy link
Contributor

🎉 This PR is included in version 1.48.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@brian-patrick-3
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srpriyankashetty srpriyankashetty srpriyankashetty approved these changes

@brian-patrick-3 brian-patrick-3 brian-patrick-3 approved these changes

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Radio button component – Button and label are not grayed out when disabled
3 participants
@tulasigudibanda @brian-patrick-3 @srpriyankashetty