Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Update image used by k8s-tools #255

Closed

Conversation

m00g3n
Copy link
Contributor

@m00g3n m00g3n commented Aug 16, 2022

Description

Update image used by k8s-tools to use SHA256 instead tags.

Changes proposed in this pull request:

  • update alpine image

Related issue(s)

@m00g3n m00g3n requested a review from a team as a code owner August 16, 2022 14:11
@m00g3n m00g3n requested review from halamix2 and dekiel August 16, 2022 14:11
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 16, 2022
@halamix2
Copy link
Member

This would disable dependabot autobumps

@dekiel
Copy link
Contributor

dekiel commented Aug 19, 2022

@m00g3n why we need this change?

@m00g3n
Copy link
Contributor Author

m00g3n commented Aug 22, 2022

@dekiel we wanted to make sure we will not get accidental changes which may happen in case we use tags (like here)

@dekiel
Copy link
Contributor

dekiel commented Aug 22, 2022

@m00g3n If you don't want to have automated updates can you stick to the image SHA in files where you use k8s-tools image?

@dekiel dekiel removed their request for review September 6, 2022 15:13
@halamix2
Copy link
Member

We won't implement SHA in the FROM field, as this would break Dependabot.
The k8s-tools image can still be used and referenced by SHA

@halamix2 halamix2 closed this Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants