Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The image-syncer documentation update #11948

Merged
merged 5 commits into from
Sep 24, 2024
Merged

The image-syncer documentation update #11948

merged 5 commits into from
Sep 24, 2024

Conversation

dekiel
Copy link
Contributor

@dekiel dekiel commented Sep 23, 2024 •
edited
Loading

Makefile is not used.

Description

Update of image-syncer documentation to reflect recent migration to the github actions.

Changes proposed in this pull request:

  • Added user guide section.
  • Added developer guide section.
  • Added example workflow calling image-syncer reusable workflow.
  • Replaced list of flags with link to the code.

Related issue(s)
See #11384

@dekiel
User guide section.
f1430ee 
Makefile is not used.
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 23, 2024
@dekiel dekiel changed the title User guide section. The image-syncer documentation update Sep 23, 2024
@dekiel dekiel marked this pull request as ready for review September 23, 2024 21:20
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@dekiel dekiel requested review from akiioto and Sawthis September 23, 2024 21:20
akiioto
akiioto reviewed Sep 24, 2024
View reviewed changes
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
akiioto
akiioto reviewed Sep 24, 2024
View reviewed changes
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
akiioto
akiioto reviewed Sep 24, 2024
View reviewed changes
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
@dekiel dekiel requested a review from akiioto September 24, 2024 08:47
IwonaLanger
IwonaLanger reviewed Sep 24, 2024
View reviewed changes
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
cmd/image-syncer/README.md Outdated Show resolved Hide resolved
@dekiel dekiel requested a review from IwonaLanger September 24, 2024 12:20
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 24, 2024
@kyma-bot kyma-bot merged commit 387f357 into kyma-project:main Sep 24, 2024
4 checks passed
@dekiel dekiel deleted the syncer-docs branch September 24, 2024 12:59
@dekiel dekiel assigned dekiel and unassigned akiioto Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@akiioto akiioto akiioto approved these changes

@mmitoraj mmitoraj Awaiting requested review from mmitoraj mmitoraj is a code owner

@NHingerl NHingerl Awaiting requested review from NHingerl NHingerl is a code owner

@grego952 grego952 Awaiting requested review from grego952 grego952 is a code owner

@nataliasitko nataliasitko Awaiting requested review from nataliasitko nataliasitko is a code owner

@neighbors-dev-bot neighbors-dev-bot Awaiting requested review from neighbors-dev-bot neighbors-dev-bot is a code owner

@Sawthis Sawthis Awaiting requested review from Sawthis Sawthis is a code owner automatically assigned from kyma-project/prow

Assignees

@dekiel dekiel

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dekiel @kyma-bot @akiioto @IwonaLanger