Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Optimize reconciliation triggered by the self-monitor webhook #935

Merged

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Apr 2, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Split flowheath package into alertrules and prober. alertrules package defines which rules are rendered, which pipelines are supported, and exposes utilities that can be use by the prober and webhook packages (e.g. for rule matching).
  • Implement pipeline filtering in the webhook, so that only the affected resource is reconciled.
  • Simplify rule name handling.

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2024
@skhalash skhalash marked this pull request as ready for review April 3, 2024 12:37
@skhalash skhalash requested a review from a team as a code owner April 3, 2024 12:37
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2024
@skhalash skhalash added this to the 1.13.0 milestone Apr 3, 2024
@skhalash skhalash added area/metrics MetricPipeline area/traces TracePipeline labels Apr 3, 2024
@skhalash
Copy link
Collaborator Author

skhalash commented Apr 3, 2024

/test pull-telemetry-manager-build

1 similar comment
@skhalash
Copy link
Collaborator Author

skhalash commented Apr 3, 2024

/test pull-telemetry-manager-build

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2024
@skhalash
Copy link
Collaborator Author

skhalash commented Apr 3, 2024

/test pre-telemetry-manager-presubmit-scanner

@skhalash
Copy link
Collaborator Author

skhalash commented Apr 3, 2024

/test pull-telemetry-manager-build

@skhalash skhalash changed the title fix: Optimize reconciliation triggered by the self-monitor webhook chore: Optimize reconciliation triggered by the self-monitor webhook Apr 3, 2024
@skhalash skhalash added the kind/chore Categorizes issue or PR as related to a chore. label Apr 3, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 4, 2024
@kyma-bot kyma-bot merged commit 05d90fd into kyma-project:main Apr 4, 2024
26 checks passed
@skhalash skhalash deleted the optimize-webhook-based-reconciliations branch April 30, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants