Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Self-monitor webhook E2E test #932

Merged
merged 10 commits into from
Mar 28, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Mar 27, 2024

Description

Changes proposed in this pull request (what was done and why):

  • Clean up existing self-monitor tests:
    • Remove irrelevant test cases
    • Remove a misleading verifier, the telemetry flow health check has to be added to the existing status verifier when the feature is released
    • Remove operational labels since we are not executing it in the upgrade job yet
    • Generate telemetry using telemetrygen
  • Extend Prometheus matchers to be able to search for a metric with a specific key/label and a specific value
  • Add a test to check if the webhook metric is incremented. Split metrics and traces self-monitor jobs, so they do not share the same manager instance and, thus, cannot influence the results of each other

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2024
@skhalash skhalash marked this pull request as ready for review March 27, 2024 19:16
@skhalash skhalash requested a review from a team as a code owner March 27, 2024 19:16
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2024
@skhalash skhalash added the area/tests Writing/adding/Refactoring tests or checks label Mar 28, 2024
@skhalash skhalash added this to the 1.13.0 milestone Mar 28, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 28, 2024
@kyma-bot kyma-bot merged commit 3c64d30 into kyma-project:main Mar 28, 2024
30 checks passed
@a-thaler a-thaler added the kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario. label Apr 8, 2024
@skhalash skhalash deleted the self-monitor-webhook-e2e-test branch April 30, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Writing/adding/Refactoring tests or checks cla: yes Indicates the PR's author has signed the CLA. kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants