Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ADR: Do not make prometheus part of the Istio service mesh #758

Merged
merged 8 commits into from
Feb 2, 2024
Merged

docs: ADR: Do not make prometheus part of the Istio service mesh #758

merged 8 commits into from
Feb 2, 2024

Conversation

rakesh-garimella
Copy link
Contributor

Description

Changes proposed in this pull request (what was done and why):

  • The ADR highlights why we dont want to make prometheus part of the istio service mesh.

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@rakesh-garimella rakesh-garimella added area/metrics MetricPipeline kind/decision Marks a decision document labels Jan 30, 2024
@rakesh-garimella rakesh-garimella requested a review from a team as a code owner January 30, 2024 10:07
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2024
@rakesh-garimella rakesh-garimella changed the title docs: ADR for making prometheus not a part of the Istio service mesh. docs: Architecture decision record for making prometheus not a part of the Istio service mesh. Jan 30, 2024
@rakesh-garimella rakesh-garimella changed the title docs: Architecture decision record for making prometheus not a part of the Istio service mesh. docs: Do not make prometheus part of the Istio service mesh ADR. Jan 30, 2024
@rakesh-garimella rakesh-garimella changed the title docs: Do not make prometheus part of the Istio service mesh ADR. docs: Do not make prometheus part of the Istio service mesh ADR Jan 30, 2024
@rakesh-garimella rakesh-garimella added area/logs LogPipeline area/traces TracePipeline do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 30, 2024
NHingerl
NHingerl reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@NHingerl NHingerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor language editing

docs/contributor/arch/004-do-not-make-prometheus-part of-the-istio-service-mesh.md Outdated Show resolved Hide resolved
docs/contributor/arch/004-do-not-make-prometheus-part of-the-istio-service-mesh.md Outdated Show resolved Hide resolved
docs/contributor/arch/004-do-not-make-prometheus-part of-the-istio-service-mesh.md Outdated Show resolved Hide resolved
docs/contributor/arch/004-do-not-make-prometheus-part of-the-istio-service-mesh.md Outdated Show resolved Hide resolved
@rakesh-garimella rakesh-garimella mentioned this pull request Jan 30, 2024
Closed
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2024
@rakesh-garimella rakesh-garimella changed the title docs: Do not make prometheus part of the Istio service mesh ADR docs: ADR: Do not make prometheus part of the Istio service mesh Feb 2, 2024
skhalash
skhalash previously approved these changes Feb 2, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 2, 2024
grego952
grego952 reviewed Feb 2, 2024
View reviewed changes
docs/contributor/arch/005-do-not-make-prometheus-part of-the-istio-service-mesh.md Outdated Show resolved Hide resolved
docs/contributor/arch/005-do-not-make-prometheus-part of-the-istio-service-mesh.md Outdated Show resolved Hide resolved
docs/contributor/arch/005-do-not-make-prometheus-part of-the-istio-service-mesh.md Outdated Show resolved Hide resolved
docs/contributor/arch/005-do-not-make-prometheus-part of-the-istio-service-mesh.md Outdated Show resolved Hide resolved
docs/contributor/arch/005-do-not-make-prometheus-part of-the-istio-service-mesh.md Outdated Show resolved Hide resolved
docs/contributor/arch/005-do-not-make-prometheus-part of-the-istio-service-mesh.md Outdated Show resolved Hide resolved
docs/contributor/arch/005-do-not-make-prometheus-part of-the-istio-service-mesh.md Outdated Show resolved Hide resolved
@rakesh-garimella @grego952
Apply suggestions from code review
abd6425 
Co-authored-by: Grzegorz Karaluch <[email protected]>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Feb 2, 2024
@rakesh-garimella @grego952
Apply suggestions from code review
47be4d3 
Co-authored-by: Grzegorz Karaluch <[email protected]>
@skhalash skhalash mentioned this pull request Feb 2, 2024
Merged
8 tasks
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 2, 2024
@skhalash
Copy link
Collaborator

skhalash commented Feb 2, 2024

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@kyma-bot kyma-bot merged commit d99bcaa into kyma-project:main Feb 2, 2024
7 checks passed
@a-thaler a-thaler added this to the 1.9.0 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl left review comments

@grego952 grego952 grego952 approved these changes

@skhalash skhalash skhalash left review comments

Assignees

@skhalash skhalash

@grego952 grego952

Labels
area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/decision Marks a decision document lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rakesh-garimella @skhalash @grego952 @NHingerl @a-thaler @kyma-bot