Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add Integrate Prometheus with Telemetry Manager using Alerting ADR #703

Merged
merged 33 commits into from
Jan 12, 2024
Merged

docs: Add Integrate Prometheus with Telemetry Manager using Alerting ADR #703

merged 33 commits into from
Jan 12, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Jan 10, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Add an ADR describing Prometheus Integration using Alerting
  • Add a PoC document

Changes refer to particular issues, PRs or documents:

#526

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Jan 10, 2024
@skhalash skhalash changed the title Prometheus integration poc [PoC] Integrate Prometheus into Metric/Trace Pipeline Reconciliation Loop Jan 10, 2024
@skhalash skhalash marked this pull request as ready for review January 11, 2024 15:47
@skhalash skhalash requested review from a team as code owners January 11, 2024 15:47
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2024
@skhalash skhalash added kind/decision Marks a decision document area/traces TracePipeline area/metrics MetricPipeline labels Jan 11, 2024
@skhalash skhalash changed the title [PoC] Integrate Prometheus into Metric/Trace Pipeline Reconciliation Loop docs: Add Integrate Prometheus with Telemetry Manager using Alerting ADR Jan 11, 2024
@skhalash skhalash added this to the 1.7.0 milestone Jan 11, 2024
NHingerl
NHingerl reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@NHingerl NHingerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent writing! Just very minor suggestions for language editing. I'm impressed!

docs/contributor/arch/003-integrate-prometheus-with-telemetry-manager-using-alerting.md Outdated Show resolved Hide resolved
docs/contributor/arch/003-integrate-prometheus-with-telemetry-manager-using-alerting.md Outdated Show resolved Hide resolved
docs/contributor/arch/003-integrate-prometheus-with-telemetry-manager-using-alerting.md Show resolved Hide resolved
docs/contributor/arch/003-integrate-prometheus-with-telemetry-manager-using-alerting.md Outdated Show resolved Hide resolved
docs/contributor/arch/003-integrate-prometheus-with-telemetry-manager-using-alerting.md Outdated Show resolved Hide resolved
docs/contributor/pocs/integrate-prometheus-with-telemetry-manager-using-alerting.md Outdated Show resolved Hide resolved
docs/contributor/pocs/integrate-prometheus-with-telemetry-manager-using-alerting.md Outdated Show resolved Hide resolved
docs/contributor/pocs/integrate-prometheus-with-telemetry-manager-using-alerting.md Outdated Show resolved Hide resolved
docs/contributor/pocs/integrate-prometheus-with-telemetry-manager-using-alerting.md Outdated Show resolved Hide resolved
docs/contributor/pocs/integrate-prometheus-with-telemetry-manager-using-alerting.md Outdated Show resolved Hide resolved
Stanislav Khalash and others added 14 commits January 12, 2024 09:44
@NHingerl
Update docs/contributor/arch/003-integrate-prometheus-with-telemetry-…
052c18d 
…manager-using-alerting.md

Co-authored-by: Nina Hingerl <[email protected]>
@NHingerl
Update docs/contributor/arch/003-integrate-prometheus-with-telemetry-…
1f6648c 
…manager-using-alerting.md

Co-authored-by: Nina Hingerl <[email protected]>
@NHingerl
Update docs/contributor/arch/003-integrate-prometheus-with-telemetry-…
afa8593 
…manager-using-alerting.md

Co-authored-by: Nina Hingerl <[email protected]>
@NHingerl
Update docs/contributor/arch/003-integrate-prometheus-with-telemetry-…
70de51d 
…manager-using-alerting.md

Co-authored-by: Nina Hingerl <[email protected]>
@NHingerl
Update docs/contributor/arch/003-integrate-prometheus-with-telemetry-…
28c0345 
…manager-using-alerting.md

Co-authored-by: Nina Hingerl <[email protected]>
@NHingerl
Update docs/contributor/pocs/integrate-prometheus-with-telemetry-mana…
4a29764 
…ger-using-alerting.md

Co-authored-by: Nina Hingerl <[email protected]>
@NHingerl
Update docs/contributor/arch/003-integrate-prometheus-with-telemetry-…
c5c35cc 
…manager-using-alerting.md

Co-authored-by: Nina Hingerl <[email protected]>
@NHingerl
Update docs/contributor/pocs/integrate-prometheus-with-telemetry-mana…
cef7518 
…ger-using-alerting.md

Co-authored-by: Nina Hingerl <[email protected]>
@NHingerl
Update docs/contributor/pocs/integrate-prometheus-with-telemetry-mana…
675b54e 
…ger-using-alerting.md

Co-authored-by: Nina Hingerl <[email protected]>
@skhalash
Fix list
dded73e
@skhalash
Fix code blocks
d32436b
@skhalash
Improve readability
58524fe
@NHingerl
Update docs/contributor/arch/003-integrate-prometheus-with-telemetry-…
9036181 
…manager-using-alerting.md

Co-authored-by: Nina Hingerl <[email protected]>
@skhalash
Merge branch 'prometheus-integration-poc' of github.com:skhalash/tele…
1ea8f95 
…metry-manager into prometheus-integration-poc
chrkl
chrkl previously approved these changes Jan 12, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 12, 2024
@grego952
Update docs/contributor/arch/003-integrate-prometheus-with-telemetry-…
69954b8 
…manager-using-alerting.md

Co-authored-by: Grzegorz Karaluch <[email protected]>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 12, 2024
Stanislav Khalash and others added 2 commits January 12, 2024 12:15
@grego952
Update docs/contributor/arch/003-integrate-prometheus-with-telemetry-…
bbe8c68 
…manager-using-alerting.md

Co-authored-by: Grzegorz Karaluch <[email protected]>
@grego952
Update docs/contributor/arch/003-integrate-prometheus-with-telemetry-…
55660d0 
…manager-using-alerting.md

Co-authored-by: Grzegorz Karaluch <[email protected]>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 12, 2024
@kyma-bot kyma-bot merged commit d03acb0 into kyma-project:main Jan 12, 2024
7 checks passed
@skhalash skhalash deleted the prometheus-integration-poc branch January 12, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl left review comments

@grego952 grego952 grego952 approved these changes

@chrkl chrkl chrkl left review comments

Assignees

@chrkl chrkl

@grego952 grego952

Labels
area/metrics MetricPipeline area/traces TracePipeline cla: yes Indicates the PR's author has signed the CLA. kind/decision Marks a decision document lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@skhalash @kyma-bot @chrkl @grego952 @NHingerl