Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fetch all history in Github Release workflow #619

Merged
merged 1 commit into from
Dec 11, 2023
Merged

chore: Fetch all history in Github Release workflow #619

merged 1 commit into from
Dec 11, 2023

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Dec 10, 2023 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • By default, the Checkout GitHub action only fetches a single commit. As a result, goreleaser will not be able to create the changelogs since the previous tags are not fetched. We need to set fetch-depth: 0 to fetch all tags as documented here.

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@shorim shorim added area/ci Test automation kind/chore Categorizes issue or PR as related to a chore. labels Dec 10, 2023
@shorim shorim added this to the 1.6.0 milestone Dec 10, 2023
@shorim shorim requested a review from a team as a code owner December 10, 2023 23:52
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 10, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 11, 2023
@kyma-bot kyma-bot merged commit 4085d0b into kyma-project:main Dec 11, 2023
23 checks passed
rakesh-garimella pushed a commit to rakesh-garimella/telemetry-manager that referenced this pull request Dec 14, 2023
@shorim @rakesh-garimella
chore: Fetch all history in Github Release workflow (kyma-project#619)
988cdea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrkl chrkl chrkl approved these changes

Assignees

@chrkl chrkl

Labels
area/ci Test automation cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shorim @chrkl @kyma-bot