Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add github actions for integration tests #496

Merged
merged 12 commits into from
Oct 30, 2023
Merged

chore: Add github actions for integration tests #496

merged 12 commits into from
Oct 30, 2023

Conversation

a-thaler
Copy link
Collaborator

@a-thaler a-thaler commented Oct 27, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add integration jobs to new "integration" GH action job
  • Add lint manifests to "governance" GH action job
  • Add golangci linting to new static "code checks" GH action job
  • Add unit tests to new static "code checks" GH action job
  • Splitted k3d provisioning into provision and image build
  • Download golangci-lint binaries now
  • Added slack notification for gardener job

Related Issues and Documents

Closes:

Related issues:
#480

Traceability

  • The PR is linked to a GitHub Issue.
  • New features have a milestone label set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub Issue has a respective area label.
  • The follow-up issues (if any) are linked in the Related Issues section.

Testability

The feature is unit-tested:

  • Yes.
  • No, because unit tests are not needed.
  • No, because of ...

The feature is e2e-tested:

  • Yes.
  • No, because e2e-tests are not needed.
  • No, because of ...

Tests conducted for the PR:

Codebase

  • My code follows the Effective Go style guidelines.
  • The code was planned and designed following the defined architecture and the separation of concerns.
  • The code has sufficient comments, particularly for all hard-to-understand areas.
  • This PR adds value and shows no feature creep.
  • I have augmented the test suite that proves my fix is effective or that my feature works.
  • Adjusted the documentation if the change is user-facing.

@a-thaler a-thaler requested a review from a team as a code owner October 27, 2023 14:44
@kyma-bot kyma-bot added area/ci Test automation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2023
@a-thaler a-thaler added kind/chore Categorizes issue or PR as related to a chore. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2023
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2023
@a-thaler
Copy link
Collaborator Author

/retest

1 similar comment
@a-thaler
Copy link
Collaborator Author

/retest

skhalash
skhalash requested changes Oct 30, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
.github/workflows/pull-code-checks.yml Outdated Show resolved Hide resolved
.github/template/prepare-checks/action.yaml Outdated Show resolved Hide resolved
@a-thaler a-thaler requested a review from a team as a code owner October 30, 2023 12:49
skhalash
skhalash previously approved these changes Oct 30, 2023
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 30, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 30, 2023
@a-thaler
Copy link
Collaborator Author

/retest

NHingerl
NHingerl reviewed Oct 30, 2023
View reviewed changes
docs/contributor/governance.md
### Linters in action

The following linters are configured and integrated as a CI stage using a [ProwJob](https://github.com/kyma-project/test-infra/blob/main/prow/jobs/kyma/components/kyma-components-static-checks.yaml#L6).
The following linters are configured and integrated as a CI stage using a [Github Action](./../../.github/workflows/pull-code-checks.yml).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following linters are configured and integrated as a CI stage using a [Github Action](./../../.github/workflows/pull-code-checks.yml).
The following linters are configured and integrated as a CI stage using a [Github Action](./../../.github/workflows/pull-code-checks.yml):

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to merge it after finally having all that jobs green. Could we keep that one character wrong for now? As it was before

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 30, 2023
@a-thaler a-thaler merged commit 5bffebc into kyma-project:main Oct 30, 2023
11 of 12 checks passed
@a-thaler a-thaler deleted the action branch October 30, 2023 14:56
@chrkl chrkl mentioned this pull request Oct 30, 2023
Closed
17 tasks
@a-thaler a-thaler added this to the 1.3.0 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NHingerl NHingerl NHingerl approved these changes

@chrkl chrkl chrkl approved these changes

@skhalash skhalash skhalash left review comments

Assignees

@chrkl chrkl

@skhalash skhalash

@NHingerl NHingerl

Labels
area/ci Test automation kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@a-thaler @chrkl @skhalash @NHingerl @kyma-bot