Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix flaky tests by really waiting for manager readiness #1699

Merged
merged 4 commits into from
Dec 18, 2024
Merged

test: Fix flaky tests by really waiting for manager readiness #1699

merged 4 commits into from
Dec 18, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Dec 18, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Wait for readiness probe to succeed which ensures that the webhook certs are generated and the webhooks are configured

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash added area/tests Writing/adding/Refactoring tests or checks kind/flaky-test Categorizes issue or PR as related to a flaky test. labels Dec 18, 2024
@skhalash skhalash added this to the 1.31.0 milestone Dec 18, 2024
@skhalash skhalash requested a review from a team as a code owner December 18, 2024 12:16
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@skhalash skhalash enabled auto-merge (squash) December 18, 2024 12:56
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2024
@skhalash skhalash merged commit 108c6bc into kyma-project:main Dec 18, 2024
46 of 48 checks passed
@skhalash skhalash mentioned this pull request Dec 19, 2024
Merged
6 tasks
TeodorSAP added a commit that referenced this pull request Jan 14, 2025
@TeodorSAP
Revert "test: Fix flaky tests by really waiting for manager readiness (…
d1ff330 
…#1699)"

This reverts commit 108c6bc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hisarbalik hisarbalik hisarbalik approved these changes

Assignees

@hisarbalik hisarbalik

Labels
area/tests Writing/adding/Refactoring tests or checks cla: yes Indicates the PR's author has signed the CLA. kind/flaky-test Categorizes issue or PR as related to a flaky test. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skhalash @hisarbalik @kyma-bot