Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove flaky telemetry override e2e test #1690

Merged
merged 1 commit into from
Dec 17, 2024
Merged

chore: Remove flaky telemetry override e2e test #1690

merged 1 commit into from
Dec 17, 2024

Conversation

hisarbalik
Copy link
Contributor

@hisarbalik hisarbalik commented Dec 17, 2024 •
edited by skhalash
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Remove flaky test case, will be rewritten in a follow-up PR

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@hisarbalik hisarbalik requested a review from a team as a code owner December 17, 2024 11:48
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 17, 2024
@hisarbalik hisarbalik added area/tests Writing/adding/Refactoring tests or checks kind/flaky-test Categorizes issue or PR as related to a flaky test. kind/chore Categorizes issue or PR as related to a chore. area/manager Manager or module changes and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. kind/flaky-test Categorizes issue or PR as related to a flaky test. labels Dec 17, 2024
@skhalash skhalash changed the title chore: Remove tTelemetry override e2e test chore: Remove flaky telemetry override e2e test Dec 17, 2024
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 17, 2024
@skhalash skhalash added this to the 1.31.0 milestone Dec 17, 2024
@skhalash skhalash mentioned this pull request Dec 17, 2024
Merged
6 tasks
@skhalash skhalash enabled auto-merge (squash) December 17, 2024 12:06
@skhalash skhalash merged commit 643c6a4 into kyma-project:main Dec 17, 2024
76 of 100 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 17, 2024
@skhalash skhalash deleted the remove-telemtry-override-e2e-test branch December 17, 2024 12:07
jeffreylimnardy pushed a commit to jeffreylimnardy/telemetry-manager that referenced this pull request Dec 18, 2024
@hisarbalik @jeffreylimnardy
chore: Remove flaky telemetry override e2e test (kyma-project#1690)
4544f37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/manager Manager or module changes area/tests Writing/adding/Refactoring tests or checks kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hisarbalik @skhalash @kyma-bot