Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix build-image after introducing merge queue #1676

Merged
merged 1 commit into from
Dec 13, 2024
Merged

chore: Fix build-image after introducing merge queue #1676

merged 1 commit into from
Dec 13, 2024

Conversation

jeffreylimnardy
Copy link
Contributor

Description

Changes proposed in this pull request (what was done and why):

  • Fix bad shell script in build-image create tag step
  • Fix outdated variable name COMMIT_SHA in await_image.sh script

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@jeffreylimnardy jeffreylimnardy added area/ci Test automation kind/chore Categorizes issue or PR as related to a chore. labels Dec 13, 2024
@jeffreylimnardy jeffreylimnardy requested a review from a team as a code owner December 13, 2024 12:40
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2024
@k15r k15r merged commit 9eb53a2 into kyma-project:main Dec 13, 2024
25 of 57 checks passed
@a-thaler a-thaler added this to the 1.30.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/ci Test automation cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.30.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffreylimnardy @k15r @a-thaler @kyma-bot