Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Refactor unit-tests to use golden files #1670

Merged
merged 5 commits into from
Dec 18, 2024
Merged

chore: Refactor unit-tests to use golden files #1670

merged 5 commits into from
Dec 18, 2024

Conversation

jeffreylimnardy
Copy link
Contributor

@jeffreylimnardy jeffreylimnardy commented Dec 11, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Change self monitor unit tests to use golden files
  • Refactor agent for it to be easier to add new tests (e.g. for log agent in the future)
  • Change fluent bit unit tests to use golden files

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2024
@jeffreylimnardy jeffreylimnardy changed the title chore: Refactor tests to ues Golden file fluent selfmon chore: Refactor tests to use golden files Dec 11, 2024
@jeffreylimnardy jeffreylimnardy changed the title chore: Refactor tests to use golden files chore: Refactor unit-tests to use golden files Dec 11, 2024
@jeffreylimnardy jeffreylimnardy added the area/tests Writing/adding/Refactoring tests or checks label Dec 11, 2024
@jeffreylimnardy jeffreylimnardy changed the title chore: Refactor unit-tests to use golden files test: Refactor unit-tests to use golden files Dec 11, 2024
@jeffreylimnardy jeffreylimnardy added the kind/chore Categorizes issue or PR as related to a chore. label Dec 11, 2024
@jeffreylimnardy jeffreylimnardy changed the title test: Refactor unit-tests to use golden files chore: Refactor unit-tests to use golden files Dec 11, 2024
@jeffreylimnardy jeffreylimnardy added this to the 1.30.0 milestone Dec 11, 2024
@jeffreylimnardy jeffreylimnardy marked this pull request as ready for review December 11, 2024 13:17
@jeffreylimnardy jeffreylimnardy requested a review from a team as a code owner December 11, 2024 13:17
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2024
@jeffreylimnardy jeffreylimnardy added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 11, 2024
@jeffreylimnardy jeffreylimnardy force-pushed the golden-file-fluent-selfmon branch from 69d7d94 to 3691c52 Compare December 16, 2024 10:55
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 16, 2024
@skhalash skhalash self-assigned this Dec 17, 2024
@skhalash skhalash removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@skhalash skhalash modified the milestones: 1.30.0, 1.31.0 Dec 17, 2024
@jeffreylimnardy jeffreylimnardy requested a review from a team as a code owner December 18, 2024 10:12
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 18, 2024
@jeffreylimnardy jeffreylimnardy force-pushed the golden-file-fluent-selfmon branch from a693e13 to 6018d89 Compare December 18, 2024 10:19
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2024
@jeffreylimnardy jeffreylimnardy merged commit d26f95d into kyma-project:main Dec 18, 2024
50 of 52 checks passed
TeodorSAP added a commit that referenced this pull request Jan 14, 2025
@TeodorSAP
Revert "chore: Refactor unit-tests to use golden files (#1670)"
3f95d1b 
This reverts commit d26f95d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skhalash skhalash skhalash approved these changes

Assignees

@skhalash skhalash

Labels
area/tests Writing/adding/Refactoring tests or checks cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffreylimnardy @skhalash @kyma-bot