Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove unneeded operator flags #1527

Merged
merged 29 commits into from
Oct 17, 2024
Merged

feat: Remove unneeded operator flags #1527

merged 29 commits into from
Oct 17, 2024

Conversation

skhalash
Copy link
Collaborator

@skhalash skhalash commented Oct 15, 2024 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

  • Remove CLI unused CLI flags and converted them to constants
  • Cleanup LogPipeline validation since the forbidden plugin are no longer configurable
  • Fix sample

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@skhalash skhalash added the area/manager Manager or module changes label Oct 15, 2024
@skhalash skhalash requested a review from a team as a code owner October 15, 2024 15:08
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 15, 2024
@skhalash skhalash changed the title wip: Remove unneeded operator flags cleanup: Remove unneeded operator flags Oct 16, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
@skhalash skhalash changed the title cleanup: Remove unneeded operator flags feat: Remove unneeded operator flags Oct 16, 2024
@skhalash skhalash added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 16, 2024
@skhalash skhalash added this to the 1.26.0 milestone Oct 16, 2024
@skhalash skhalash mentioned this pull request Oct 16, 2024
Merged
6 tasks
k15r
k15r reviewed Oct 16, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
k15r
k15r reviewed Oct 17, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
k15r
k15r reviewed Oct 17, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
@skhalash skhalash requested a review from k15r October 17, 2024 08:39
@skhalash skhalash enabled auto-merge (squash) October 17, 2024 08:40
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 17, 2024
@skhalash skhalash merged commit 0e1929c into kyma-project:main Oct 17, 2024
35 checks passed
@skhalash skhalash deleted the remove-unneded-operator-flags branch October 17, 2024 08:42
@shorim shorim mentioned this pull request Nov 5, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k15r k15r k15r approved these changes

Assignees

@k15r k15r

Labels
area/manager Manager or module changes cla: yes Indicates the PR's author has signed the CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skhalash @k15r @kyma-bot